Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issues with recent imagery fetches #3690

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Fix/issues with recent imagery fetches #3690

merged 2 commits into from
Jan 18, 2019

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jan 17, 2019

We had two bugs:

  1. We were sorting the tiles after the fetch before selecting the best tile from the front of the array causing the tile url never to be found
  2. When moving the location of the center tile there wasnt an infinite loop created by not checking against previous props for positionInsideTile property.

These have been address and some small improvements to style.

@edbrett edbrett requested a review from dfrico January 17, 2019 18:47
@edbrett edbrett added hotfix Urgent fixes to production bugs develop Any PR that is ready to be merged to develop labels Jan 17, 2019
dfrico
dfrico approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@dfrico dfrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiles (and everything) looking good 👍

@edbrett edbrett merged commit 1256cc7 into develop Jan 18, 2019
@edbrett edbrett deleted the fix/recent-imagery-tile-updates branch January 18, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrico dfrico dfrico approved these changes

Assignees
No one assigned
Labels
develop Any PR that is ready to be merged to develop hotfix Urgent fixes to production bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @dfrico